On 2/27/25 7:54 PM, Mark Michelson wrote:
> This is a series of backports of PMTUD fixes from later branches of OVN.
> I removed the "Signed-off-by" lines from the original patches and put my
> own signoffs on instead. This likely is going to make 0-day-robot angry,
> but I'm not sure what the proper procedure is when cherry-picking and
> updating patches that I did not author.
> 
> The first patch in the series also has a new "Reported-at" tag to
> indicate the issue that requested the backport of the fix.

Hi Mark,

> 
> Ales Musil (1):
>   tests: Fix flaky PMTUD flows test.
> 
> Lorenzo Bianconi (1):
>   northd: Fix pmtud for non routed traffic.
> 
> Xavier Simonart (1):
>   northd: Fix pmtud related issues.

We're missing 7e2b45df788d ("northd: Fix the match not being cleared
inside the loop.") [0].  Without it the logical flows are incorrect
which is also why the CI runs with this patchset are failing the
"portsecurity : 3 HVs, 1 LS, 3 lports/HV" test.

I have a few more comments on the individual patches.

Thanks,
Dumitru

[0] https://github.com/ovn-org/ovn/commit/7e2b45df788d

> 
>  controller/lflow.h        |   2 +-
>  controller/physical.c     |  30 +++-
>  northd/northd.c           |  44 ++++--
>  northd/ovn-northd.8.xml   |  16 ++-
>  tests/multinode-macros.at |   7 +
>  tests/multinode.at        | 164 +++++++++++++++++++++-
>  tests/ovn-controller.at   |  70 ++++++++++
>  tests/ovn-macros.at       |  31 +++++
>  tests/ovn-northd.at       | 278 ++++++++++++++++++++------------------
>  tests/ovn.at              |   5 +-
>  10 files changed, 501 insertions(+), 146 deletions(-)
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to