On 2/27/25 14:41, Alin Serdean wrote: > Sad to see the support go away, STT was performance for tunelling under > Windows.... > > Acked-by: Alin Serdean <aserd...@ovn.org <mailto:aserd...@ovn.org>> > > On Thu, Feb 27, 2025 at 2:29 PM Eelco Chaudron <echau...@redhat.com > <mailto:echau...@redhat.com>> wrote: > > > > On 27 Feb 2025, at 11:47, Ilya Maximets wrote: > > > On 2/27/25 10:30, Eelco Chaudron wrote: > >> > >> > >> On 24 Feb 2025, at 20:14, Ilya Maximets wrote: > >> > >>> STT and LISP tunnel types were deprecated and marked for removal in > >>> the following commits in the OVS 3.5 release: > >>> > >>> 3b37a6154a59 ("netdev-vport: Deprecate STT tunnel port type.") > >>> 8d7ac031c03d ("netdev-vport: Deprecate LISP tunnel port type.") > >>> > >>> Main reasons were that STT was rejected in upstream kernel and the > >>> LISP was never upstreamed as well and doesn't really have a supported > >>> implementation. Both protocols also appear to have lost their former > >>> relevance. > >>> > >>> Removing both now. While at it, also fixing some small documentation > >>> issues and comments. > >> > >> Two small nits below, but the rest of the code looks good to me. > >> > >> Acked-by: Eelco Chaudron <echau...@redhat.com > <mailto:echau...@redhat.com>> > >> > >> I did some basic testing for cases where we had an existing > configuration > >> and upgraded OVS on Linux. No Windows-specific testing as I lack the > environment. > > > > Windows build works in CI. I wouldn't expect any runtime issues > > with this change. > > That’s how I verified it too ;) > >> > >> Cheers, > >> > >> Eelco > >> > >> > >>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org > <mailto:i.maxim...@ovn.org>> > >>> --- > >> > >> <SNIP> > >> > >>> diff --git a/datapath-windows/ovsext/Debug.h > b/datapath-windows/ovsext/Debug.h > >>> index c17f0e9f8..71546ca04 100644 > >>> --- a/datapath-windows/ovsext/Debug.h > >>> +++ b/datapath-windows/ovsext/Debug.h > >>> @@ -39,10 +39,9 @@ > >>> #define OVS_DBG_OTHERS BIT32(19) > >>> #define OVS_DBG_NETLINK BIT32(20) > >>> #define OVS_DBG_TUNFLT BIT32(21) > >>> -#define OVS_DBG_STT BIT32(22) > >>> -#define OVS_DBG_CONTRK BIT32(23) > >>> -#define OVS_DBG_GENEVE BIT32(24) > >>> -#define OVS_DBG_IPFRAG BIT32(25) > >>> +#define OVS_DBG_CONTRK BIT32(22) > >>> +#define OVS_DBG_GENEVE BIT32(23) > >>> +#define OVS_DBG_IPFRAG BIT32(24) > >>> > >>> #define OVS_DBG_LAST 25 /* Set this to the last defined module > number. */ > >> > >> Should this value be changed to 24? > > > > Good catch! Will change before applying. > > > >> > >>> /* Please add above OVS_DBG_LAST. */ > >> > >> <SNIP> > >> > >>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h > >>> index 12c25d380..65c2785d3 100644 > >>> --- a/include/linux/openvswitch.h > >>> +++ b/include/linux/openvswitch.h > >>> @@ -247,8 +247,8 @@ enum ovs_vport_type { > >>> OVS_VPORT_TYPE_GRE, /* GRE tunnel. */ > >>> OVS_VPORT_TYPE_VXLAN, /* VXLAN tunnel. */ > >>> OVS_VPORT_TYPE_GENEVE, /* Geneve tunnel. */ > >>> - OVS_VPORT_TYPE_LISP = 105, /* LISP tunnel (deprecated). */ > >>> - OVS_VPORT_TYPE_STT = 106, /* STT tunnel (deprecated). */ > >>> + /* OVS_VPORT_TYPE_LISP = 105, LISP tunnel (not supported). */ > >>> + /* OVS_VPORT_TYPE_STT = 106, STT tunnel (not supported). */ > >> > >> Maybe change to (no longer supported) to make it clear that it’s not > something we lack support for, > >> but rather that it has been removed > > > > Makes sense, can change while applying as well. > > Thanks!
Thanks, Eelco, Alin and Kevin! I made the suggested changes and applied the patch. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
