On 2/26/25 16:29, Eelco Chaudron wrote:
> The additional requested comment was not included in commit
> 273a4fce951a. This patch adds the missing comment.
> 
> Related commit:
>   273a4fce951a ("netdev-offload-tc: Only install recirc flows if the parent 
> is present.")
> 
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
> ---
>  lib/netdev-offload-tc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
> index 985bb80a3..804885285 100644
> --- a/lib/netdev-offload-tc.c
> +++ b/lib/netdev-offload-tc.c
> @@ -2699,6 +2699,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match 
> *match,
>              struct tc_action *action = flower.actions;
>  
>              for (int i = 0; i < flower.action_count; i++, action++) {
> +                /* If action->chain is zero, this is not a true "goto"
> +                 * (recirculation) action, but rather a drop action.
> +                 * Since it does not involve recirculation handling,
> +                 * it should be ignored. */
>                  if (action->type == TC_ACT_GOTO && action->chain) {
>                      chain_goto = action->chain;
>                      ovs_mutex_lock(&used_chains_mutex);

Thanks, Eelco!  Applied.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to