On 3/1/25 3:00 PM, Frank Wagner wrote:
> The current implementation of the debug tool is not compatible with VC
> compiler.
> This patch disables the debug tool on Windows builds as it is not needed.
> Of course it would be better if the code could be fixed to work with VC++,
> but this is a quick fix to get the Windows build working.
>
> Signed-off-by: Frank Wagner <frank.wag...@dbosoft.eu>
>
> ---
Hi Frank,
Thanks for the patch!
> utilities/ovn-debug.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/utilities/ovn-debug.c b/utilities/ovn-debug.c
> index 0a0d2202b..cc1300f4a 100644
> --- a/utilities/ovn-debug.c
> +++ b/utilities/ovn-debug.c
> @@ -22,6 +22,7 @@
> #include "northd/northd.h"
> #include "ovn-util.h"
>
> +#ifndef _WIN32
> struct ovn_lflow_stage {
> const char *name;
> uint8_t table_id;
> @@ -171,3 +172,12 @@ main(int argc, char *argv[])
> ctx.argv = argv + optind;
> ovs_cmdl_run_command(&ctx, commands);
> }
> +
> +#else /* _WIN32 */
> +
> +/* add a stub main for windows builds */
I understand it might be a lot of work to fix the ovn-debug utility on
Windows but let's at least add a comment mentioning that. And also a
TODO.rst item where we list the actual problems? What do you think?
I think we should also list compilation issues (or the most important of
them) in the commit log.
> +int
> +main(int argc, char *argv[])
> +{
> +}
> +#endif /* _WIN32 */
>
Thanks,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
