On 3/16/25 00:11, Alin Gabriel Serdean wrote:
> This patch drops support for Microsoft 8 and 8.1 family (2012 and 2012R2).
> 
> This patch also fixes compilation on the lastest WDK and uplifts
> the solution to VStudio 2022.
> 
> Co-authored-by: Frank Wagner <[email protected]>
> Signed-off-by: Alin Gabriel Serdean <[email protected]>
> ---
>  Documentation/intro/install/windows.rst       |   8 +-
>  Makefile.am                                   |  12 -
>  datapath-windows/Package/package.VcxProj      | 234 -----------
>  datapath-windows/Package/package.VcxProj.user |  30 --
>  datapath-windows/automake.mk                  |   4 -
>  datapath-windows/ovsext.sln                   |  71 +---
>  datapath-windows/ovsext/Util.c                |  22 +-
>  datapath-windows/ovsext/ovsext.inf            |   1 +
>  datapath-windows/ovsext/ovsext.vcxproj        | 381 ++++--------------
>  datapath-windows/ovsext/ovsext.vcxproj.user   |  24 +-
>  m4/openvswitch.m4                             |   8 +-
>  windows/automake.mk                           |  14 +-
>  .../ovs-windows-installer/Driver/.gitignore   |   2 -
>  windows/ovs-windows-installer/Product.wxs     |  30 --
>  14 files changed, 104 insertions(+), 737 deletions(-)
>  delete mode 100644 datapath-windows/Package/package.VcxProj
>  delete mode 100644 datapath-windows/Package/package.VcxProj.user

Hi, Alin.  Beside the authorship and the Sign-off issues reported by
the robot, I tried this change in appveyor and it failed with:

cp : Cannot find path 
'C:\openvswitch_compile\datapath-windows\x64\Win10Debug\package' because it 
does not exist.

Do we need some update for the appveyor build to make it work?

And the commit message says that VS2022 should work now, should we
update appveyor to use that image instead of 2019?  Is it a requirement
now to use a new version?

Also, we probably need a NEWS entry saying that Win8* targets are
no longer supported.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to