On Wed, Mar 19, 2025 at 02:45:55PM +0100, Dumitru Ceara wrote: > On 3/10/25 3:16 PM, Felix Huettner via dev wrote: > > The RTPROT_OVN value has been merged to the net-next tree [1]. > > Until it is available on all systems we need to forward declares this > > value. > > > > [1]: > > https://web.git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/%3Fid%3D6002850fdfe0b4343136670a9895b6ba4ee3285b > > > > Signed-off-by: Felix Huettner <felix.huettner@stackit.cloud> > > --- > > Hi Felix, > > > v1->v2: use ifndef instead of dependency to ovs > > > > controller/route-exchange-netlink.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/controller/route-exchange-netlink.h > > b/controller/route-exchange-netlink.h > > index 1eadde491..7736168cc 100644 > > --- a/controller/route-exchange-netlink.h > > +++ b/controller/route-exchange-netlink.h > > @@ -23,11 +23,11 @@ > > #include <netinet/in.h> > > #include <net/if.h> > > > > -/* This value is arbitrary but currently unused. > > - * See the kernel rtnetlink UAPI at > > - * > > https://github.com/torvalds/linux/blob/master/include/uapi/linux/rtnetlink.h > > - * */ > > +/* These will be introduced in Linux 6.15, so they might be missing if we > > have > > + * old headers. */ > > Should we change this comment in a similar way to what was done in OVS? > > https://github.com/openvswitch/ovs/commit/15b6c25 > > That is: > /* The following definition should be available in Linux 6.15 and might be > * missing if we have older headers. */ > > > +#ifndef RTPROT_OVN > > #define RTPROT_OVN 84 > > +#endif > > > > struct in6_addr; > > struct hmap; > > If that sounds OK, I can take care of it when applying the patch.
Hi Dumitru, yes that sounds good. Thanks a lot. Felix > > Regards, > Dumitru > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
