Eelco Chaudron via dev <[email protected]> writes: > On 27 Mar 2025, at 16:10, Aaron Conole wrote: > >> Checkpatch has the ability to scan source files rather than >> exclusively scanning patch files. In this mode, some checks >> get disabled (ex: all of the header and commit message >> parsing) and the display modes are adjusted to simply print >> the file and line, rather than including the patch line >> details. >> >> When checkpatch was updated for subject parsing, it was >> inadvertently ignoring the source file mode. This means >> any checks run against a source file will always print a >> bogus subject suggestion, and warning. Fix this by not >> printing these warnings when in source file mode. This >> should have no effect on checkpatch against actual patch >> files. >> >> Additionally, introduce two simple tests to verify that >> the source file mode still functions. >> >> Fixes: 1b8fa4a66aa4 ("checkpatch: Add checks for the subject line.") >> Signed-off-by: Aaron Conole <[email protected]> > > The patch looks good to me with one small comment below. If applied during > commit, it looks good to me. > > Acked-by: Eelco Chaudron <[email protected]> >
Thanks, applied to main and back to branch-3.3 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
