On 3/31/25 8:57 AM, Frode Nordahl wrote:
> Building the OVS submodule is currently broken for the OVN CI due
> to a change in flake8 2.7.0 which introduced the F824 check [0][1].
> 
> This was tackled in OVS commit 7f4ee4395637 by disabling the check.
> 
> 0: PyCQA/flake8#1974
> 1: PyCQA/pyflakes#825
> Signed-off-by: Frode Nordahl <[email protected]>
> ---
>  ovs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovs b/ovs
> index 400db9746..7f4ee4395 160000
> --- a/ovs
> +++ b/ovs
> @@ -1 +1 @@
> -Subproject commit 400db974617abe5330a726c2c1e15f9a9efd849a
> +Subproject commit 7f4ee4395637e906563c71f4112b809fed4f3968

We shouldn't move to the main branch here.  OVN main is currently on the
branch-3.5, so we should move to the corresponding commit from that branch
instead: bb059333496a9b48d6d798b6b32108c9f2720479.

OVS' main branch contains a re changes like removal of deprecated SSL/TLS
versions and STT tunnel support.  This will need corresponding OVN changes
in the documentation and the code.  These are work in progress.
So, while it may not be a big deal to move now and fix OVN later, I think,
it's better to consume those changes together with making corresponding
OVN changes.  There is no reason to move to OVS main just now.

The commit name should also be a bit more descriptive, e.g.:

  "ovs: Update the submodule to include python F824 fix."


Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to