On 4/2/25 4:22 PM, Rosemarie O'Riorden wrote:
> On 4/2/25 6:46 AM, Dumitru Ceara wrote:
>> If a router port has more than 16 networks configured we should set the
>> flags.network_id to 0 for network whose index is greater than 16.
>>
>> This issue has been reported by coverity. Trimmed report:
>>
>> *** CID 459645: Code maintainability issues (UNUSED_VALUE)
>> /northd/northd.c: 15062 in build_lrouter_network_id_flows()
>> 15056 "flags.network_id = 0.", op->json_key,
>> 15057 OVN_MAX_NETWORK_ID + 1,
>> 15058 op->lrp_networks.ipv6_addrs[i].addr_s,
>> 15059 op->lrp_networks.ipv6_addrs[i].plen);
>> 15060 network_id = 0;
>> 15061 } else {
>> >>> CID 459645: Code maintainability issues (UNUSED_VALUE)
>> >>> Assigning value from "i" to "network_id" here, but that stored
>> >> value is overwritten before it can be used.
>> 15062 network_id = i;
>> 15063 }
>> 15064
>> 15065 ds_clear(match);
>> 15066 ds_clear(actions);
>> 15067
>>
>> Fixes: af6e83707568 ("northd: Use next-hop network for SNAT when
>> lb_force_snat_ip=router_ip.")
>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>> ---
>
> This corrects the IPv6 behavior and makes it consistent with that of
> IPv4. Looks good to me. Thanks!
>
> Acked-by: Rosemarie O'Riorden <rosema...@redhat.com>
>
Hi Rosemarie,
Thanks for the review! Applied to main, 25.03, 24.09 and 24.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
