Hi Ales

Thanks for the patch!

Looks good to me.
Acked-by: Xavier Simonart <xsimo...@redhat.com>

Thanks
Xavier

On Tue, Mar 18, 2025 at 3:54 PM Ales Musil via dev <ovs-dev@openvswitch.org>
wrote:

> Some tests would fail from time to time on transaction error when
> two controllers try to add the same FDB into DB simultaneously.
> Ignore the transaction error during cleanup.
>
> Signed-off-by: Ales Musil <amu...@redhat.com>
> ---
>  tests/ovn-macros.at | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
> index 1ef511c25..16b77cf01 100644
> --- a/tests/ovn-macros.at
> +++ b/tests/ovn-macros.at
> @@ -402,6 +402,8 @@ m4_define([OVN_CLEANUP_SBOX],[
>      # "Failed to locate tunnel to reach main chassis" happening when
> controller started e.g. before ovn-bridge-mappings is set
>      # "Transaction causes multiple rows in \"MAC_Binding\" table to have
> identical values"
>      #  happening as ovn-controller has a race condition over MAC binding
> table with other controllers (GARP).
> +    # "Transaction causes multiple rows in \"FDB\" table to have
> identical values"
> +    #  happens when there is a race between multiple ovn-controllers that
> try to create the same FDB.
>      AT_CHECK([check_logs "
>          $error
>          /connection failed (No such file or directory)/d
> @@ -409,6 +411,7 @@ m4_define([OVN_CLEANUP_SBOX],[
>          /receive tunnel port not found*/d
>          /Failed to locate tunnel to reach main chassis/d
>          /Transaction causes multiple rows.*MAC_Binding/d
> +        /Transaction causes multiple rows.*FDB/d
>      " $sbox])
>  ])
>
> --
> 2.48.1
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to