On 3/20/25 10:26, Roi Dayan via dev wrote: > Upon tunnel output failure, due to routing failure for example, add a > tunnel-void action. This action does not do anything, but it appears in > the dp-flows for better visibility for that case.
Hi, Eli. Thanks for the set! I see the issue and agree that we should have better visibility for it, but we shouldn't add new actions. We have an explicit drop action exactly for cases like this. So, instead of a new action, we need to add a new xlate_error type and generate an explicit drop action (if supported by the datapath) with this error as a drop reason. And we already have counting of such drops with coverage counters in the userspace datapath, we'll just need to add a new one for a new drop reason. See dp_update_drop_action_counter() function. Note: new xlate errors should be added to the end of the enum. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
