On Thu, Apr 17, 2025 at 04:42:28PM +0000, Dmitry Porokh via dev wrote:
> According to profiler on some loads UUID to string is pretty common
> operation and almost always it calls xasprintf in result which calls
> vsnprintf twice 1. to calculate length of resulting string 2. to print
> result to string. This patch introduces specialized function for UUID
> printing and both reduces code duplication and improves performance
> exploiting fixed size of output result.
> 
> Signed-off-by: Dmitry Porokh <dpor...@nvidia.com>

Hi Dmitry,

It might be nice to add some numbers to the commit message regarding
performance improvements.

But regardless, this seems like a nice improvement in readability to me.

Acked-by: Simon Horman <ho...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to