Bleep bloop. Greetings Dmitry Porokh, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary should end with a dot.
Subject: ovsdb: jsonrpc input offload to separate thread
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#93 FILE: lib/jsonrpc-in-normal.h:32:
uint8_t input_buffer[4096*32];
WARNING: Line is 82 characters long (recommended limit is 79)
#119 FILE: lib/jsonrpc-in-normal.h:58:
static inline struct json *jsonrpc_in_normal_poll(struct jsonrpc_in_normal
*nin) {
WARNING: Line is 88 characters long (recommended limit is 79)
ERROR: Inappropriate spacing around cast
#125 FILE: lib/jsonrpc-in-normal.h:64:
size_t used = json_parser_feed(nin->parser, (char
*)byteq_tail(&nin->input), n);
WARNING: Line is 88 characters long (recommended limit is 79)
#149 FILE: lib/jsonrpc-in-normal.h:88:
return byteq_is_empty(&nin->input) ? JSONRPC_IN_IDLE :
JSONRPC_IN_ACTIVE_WAKEUP_NOW;
WARNING: Line is 101 characters long (recommended limit is 79)
#153 FILE: lib/jsonrpc-in-normal.h:92:
jsonrpc_in_normal_fill_stream_report_data(struct jsonrpc_in_normal *nin, void
*data, size_t datasz) {
WARNING: Line is 86 characters long (recommended limit is 79)
#211 FILE: lib/jsonrpc-in-threaded.c:38:
void *jsonrpc_in_threaded_read_buffer(struct jsonrpc_in_threaded *tin, size_t
*size) {
WARNING: Line is 86 characters long (recommended limit is 79)
#220 FILE: lib/jsonrpc-in-threaded.c:47:
void jsonrpc_in_threaded_read_complete(struct jsonrpc_in_threaded *tin, size_t
size) {
WARNING: Line is 82 characters long (recommended limit is 79)
#250 FILE: lib/jsonrpc-in-threaded.c:77:
json_destroy(tin->jsons[tin->jsons_tail %
JSON_RPC_IN_NUM_PENDING_JSONS]);
WARNING: Line is 92 characters long (recommended limit is 79)
#258 FILE: lib/jsonrpc-in-threaded.c:85:
unsigned int jsonrpc_in_threaded_get_received_bytes(const struct
jsonrpc_in_threaded *tin) {
WARNING: Line is 86 characters long (recommended limit is 79)
#315 FILE: lib/jsonrpc-in-threaded.c:142:
ovs_assert(tin->jsons_head - tin->jsons_tail <
JSON_RPC_IN_NUM_PENDING_JSONS);
ERROR: Inappropriate spacing around cast
#318 FILE: lib/jsonrpc-in-threaded.c:145:
const char *tail = (const char *)byteq_tail(&tin->input);
WARNING: Line is 112 characters long (recommended limit is 79)
#348 FILE: lib/jsonrpc-in-threaded.c:175:
size_t jsonrpc_in_threaded_fill_stream_report_data(struct jsonrpc_in_threaded
*tin, void *data, size_t datasz) {
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#404 FILE: lib/jsonrpc-in-threaded.h:39:
uint8_t input_buffer[65536*2];
WARNING: Line is 85 characters long (recommended limit is 79)
#414 FILE: lib/jsonrpc-in-threaded.h:49:
void *jsonrpc_in_threaded_read_buffer(struct jsonrpc_in_threaded *tin, size_t
*size);
WARNING: Line is 85 characters long (recommended limit is 79)
#415 FILE: lib/jsonrpc-in-threaded.h:50:
void jsonrpc_in_threaded_read_complete(struct jsonrpc_in_threaded *tin, size_t
size);
WARNING: Line is 91 characters long (recommended limit is 79)
#418 FILE: lib/jsonrpc-in-threaded.h:53:
unsigned int jsonrpc_in_threaded_get_received_bytes(const struct
jsonrpc_in_threaded *tin);
WARNING: Line is 111 characters long (recommended limit is 79)
#422 FILE: lib/jsonrpc-in-threaded.h:57:
size_t jsonrpc_in_threaded_fill_stream_report_data(struct jsonrpc_in_threaded
*tin, void *data, size_t datasz);
WARNING: Line is 93 characters long (recommended limit is 79)
#557 FILE: lib/jsonrpc-in.c:123:
return jsonrpc_in_normal_wait(&input->normal); /* sic! normal does not
really wait */
WARNING: Line is 96 characters long (recommended limit is 79)
#565 FILE: lib/jsonrpc-in.c:131:
size_t jsonrpc_in_fill_stream_report_data(struct jsonrpc_in *input, void *data,
size_t datasz) {
WARNING: Line is 87 characters long (recommended limit is 79)
#568 FILE: lib/jsonrpc-in.c:134:
return jsonrpc_in_normal_fill_stream_report_data(&input->normal, data,
datasz);
WARNING: Line is 91 characters long (recommended limit is 79)
#570 FILE: lib/jsonrpc-in.c:136:
return jsonrpc_in_threaded_fill_stream_report_data(&input->threaded,
data, datasz);
WARNING: Line is 95 characters long (recommended limit is 79)
#635 FILE: lib/jsonrpc-in.h:54:
size_t jsonrpc_in_fill_stream_report_data(struct jsonrpc_in *input, void *data,
size_t datasz);
WARNING: Line is 95 characters long (recommended limit is 79)
#641 FILE: lib/jsonrpc-in.h:60:
size_t jsonrpc_in_fill_stream_report_data(struct jsonrpc_in *input, void *data,
size_t datasz);
WARNING: Line is 91 characters long (recommended limit is 79)
#680 FILE: lib/jsonrpc.c:68:
static struct jsonrpc_msg *jsonrpc_parse_received_message(struct jsonrpc *,
struct json *);
WARNING: Line is 97 characters long (recommended limit is 79)
#803 FILE: lib/jsonrpc.c:382:
size_t written = jsonrpc_in_fill_stream_report_data(rpc->input,
sdata, sizeof sdata);
WARNING: Line is 87 characters long (recommended limit is 79)
#812 FILE: lib/jsonrpc.c:391:
if (rpc->error_received != 0 && jsonrpc_in_status(rpc->input) ==
JSONRPC_IN_IDLE) {
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
