Bleep bloop. Greetings Dmitry Porokh, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary should end with a dot.
Subject: ovsdb: use static json objects to reduce memory allocator usage
WARNING: Line is 83 characters long (recommended limit is 79)
#32 FILE: include/openvswitch/json.h:70:
bool is_static; /* This json is static and points to static
data */
WARNING: Line is 80 characters long (recommended limit is 79)
#230 FILE: lib/ovsdb-idl.c:2869:
&& !strcmp(json->array.elems[0]->string, OVSDB_JSON_STR_UUID.string)
WARNING: Line is 80 characters long (recommended limit is 79)
#415 FILE: lib/ovsdb-json.c:23:
struct json OVSDB_JSON_STR_ABORT = JSON_STATIC_STRING_INITIALIZER("abort");
WARNING: Line is 82 characters long (recommended limit is 79)
#417 FILE: lib/ovsdb-json.c:25:
struct json OVSDB_JSON_STR_COMMENT =
JSON_STATIC_STRING_INITIALIZER("comment");
WARNING: Line is 81 characters long (recommended limit is 79)
#418 FILE: lib/ovsdb-json.c:26:
struct json OVSDB_JSON_STR_DELETE =
JSON_STATIC_STRING_INITIALIZER("delete");
WARNING: Line is 81 characters long (recommended limit is 79)
#420 FILE: lib/ovsdb-json.c:28:
struct json OVSDB_JSON_STR_INSERT =
JSON_STATIC_STRING_INITIALIZER("insert");
WARNING: Line is 80 characters long (recommended limit is 79)
#422 FILE: lib/ovsdb-json.c:30:
struct json OVSDB_JSON_STR_MONID = JSON_STATIC_STRING_INITIALIZER("monid");
WARNING: Line is 81 characters long (recommended limit is 79)
#423 FILE: lib/ovsdb-json.c:31:
struct json OVSDB_JSON_STR_MUTATE =
JSON_STATIC_STRING_INITIALIZER("mutate");
WARNING: Line is 85 characters long (recommended limit is 79)
#424 FILE: lib/ovsdb-json.c:32:
struct json OVSDB_JSON_STR_NAMED_UUID =
JSON_STATIC_STRING_INITIALIZER("named-uuid");
WARNING: Line is 81 characters long (recommended limit is 79)
#425 FILE: lib/ovsdb-json.c:33:
struct json OVSDB_JSON_STR_SELECT =
JSON_STATIC_STRING_INITIALIZER("select");
WARNING: Line is 81 characters long (recommended limit is 79)
#427 FILE: lib/ovsdb-json.c:35:
struct json OVSDB_JSON_STR_UPDATE =
JSON_STATIC_STRING_INITIALIZER("update");
WARNING: Line is 80 characters long (recommended limit is 79)
#430 FILE: lib/ovsdb-json.c:38:
struct json OVSDB_JSON_STR__UUID = JSON_STATIC_STRING_INITIALIZER("_uuid");
Please check this out. If you feel there has been an error, please email
acon...@redhat.com
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
