On Thu, May 15, 2025 at 9:55 AM Roi Dayan <r...@nvidia.com> wrote: > >>>> @@ -1831,6 +1835,10 @@ netdev_dpdk_destruct(struct netdev *netdev) > >>>> } > >>>> } > >>>> > >>>> + rte_eth_dev_callback_unregister(RTE_ETH_ALL, > >>>> + RTE_ETH_EVENT_INTR_RESET, > >>>> + dpdk_eth_event_callback, NULL); > >>> > >>> This unregisters the callback for *all* DPDK ports, not just the port > >>> associated to this OVS netdev. > >>> > >> > >> hmm, let me go over the patch again then. the issue is re-adding dpdk-port > >> to a bridge > >> We noticed hugepages allocation keeps increasing and not freed. we traced > >> it to > >> type INTR_USER_CALLBACK which is registered by this callback. > >> > > > > I see it shouldn't have happen. init should have been called once. > > The leak does look from rte_eth_dev_callback_register()/INTR_USER_CALLBACK > > so > > I need to recheck how it happens on re-adding a port. It did stop adding > > the unregister > > callback. sorry for the hassle for now i'll go over this again. > > > > My mistake, should have been something else. please ignore the patch. sorry > again.
No problem, it made me look again at this callback stuff. And now I have some doubt it works with port hotplugging (like if a port is not known at rte_eal_init). -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
