On 17/05/2025 0:42, Ilya Maximets wrote:
> On 5/15/25 9:51 AM, Roi Dayan via dev wrote:
>> Allow to set custom core file size with --ulimit-core argument.
>> This argument can be set in ovs config file
>> in rhel can set OPTIONS in /etc/sysconfig/openvswitch
>> in debian can set OVS_CTL_OPTS in /etc/default/openvswitch-switch.
>>
>> Signed-off-by: Roi Dayan <r...@nvidia.com>
>> Acked-by: Gaetan Rivet <gaet...@nvidia.com>
>> ---
>> utilities/ovs-ctl.in | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
>> index 077e1f65a321..c65c76812ed5 100644
>> --- a/utilities/ovs-ctl.in
>> +++ b/utilities/ovs-ctl.in
>> @@ -110,7 +110,7 @@ check_core_config () {
>> ulimit -c unlimited
>> fi
>> elif test X"$FORCE_COREFILES" = Xyes; then
>> - ulimit -c 67108864
>> + ulimit -c $ULIMIT_CORE
>> fi
>> }
>>
>> @@ -357,6 +357,7 @@ set_defaults () {
>> OVSDB_SERVER_UMASK=
>> OVS_VSWITCHD_UMASK=
>> OOM_SCORE=
>> + ULIMIT_CORE=67108864
>>
>> DB_FILE=$dbdir/conf.db
>> DB_SOCK=$rundir/db.sock
>> @@ -450,6 +451,7 @@ Less important options for "start", "restart" and
>> "force-reload-kmod":
>> --no-record-hostname do not attempt to determine/record system
>> hostname as part of start command
>> --oom-score=SCORE Set oom-score after starting ovs daemon.
>> + --ulimit-core=LIMIT Set ulimit core file size.
>>
>> Debugging options for "start", "restart" and "force-reload-kmod":
>> --ovsdb-server-wrapper=WRAPPER
>
> Hi, Roi. Thanks for the patch!
>
> Since you're adding new user-visible options, please, update the
> corresponding man page and the NEWS file. You may use your previous
> patch that adds --oom-score (commit ad59bb8514e2) as an example.
>
> Best regards, Ilya Maximets.
ack, missed it. thanks.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
