Hi Ales, Numan, On 5/21/25 9:23 AM, Ales Musil wrote: > On Tue, May 20, 2025 at 4:14 PM Numan Siddique <num...@ovn.org> wrote: > >> On Mon, May 19, 2025 at 10:24 AM Dumitru Ceara <dce...@redhat.com> wrote: >>> >>> We recently got an internal request to backport to branch-24.03 (LTS) >>> the feature that Numan implemented in 24.09.0 that adds support for >>> centralized routing for distributed ports [0]. >>> >>> While in general features should not be backported to older stable >>> branches, in this case the CMS (OpenStack) is hitting an issue (a bug >>> from their perspective) which cannot be fixed without OVN support for >>> centralized routing. >>> >>> The new support, introduced by [0] is guarded by an explicit NB >>> configuration, NB.Logical_Router_Port.options:centralize_routing. >>> >>> With this in mind, it seems acceptable to me to also backport the >>> feature to the LTS (branch-24.03). >>> >>> Along with it we also need to backport some prerequisite bugfix (these >>> were inadvertently not backported to LTS when they were accepted), some >>> refactor and some follow up patches. >>> >>> Aside for some minor conflicts in patch 01/11 due to features that are >>> only present in 24.09+ the rest of the patches cherry picked by this >>> series applied (almost) cleanly - some test adjustments had to be made. >>> >>> Reported-at: https://issues.redhat.com/browse/FDP-1417 >>> >>> [0] https://github.com/ovn-org/ovn/commit/8d13579 >>> >>> Ihar Hrachyshka (6): >>> northd: Don't cleanup op in ovn_port_allocate_key. >>> northd: Don't detach op->list when it wasn't used. >>> tests: Correct tunnel ids exhaustion scenario. >>> northd: Don't create pb in ls_port_init too early. >>> northd: Remove unused `sb` arg in ls_port_create. >>> northd: Remove unused nbrp arg in ls_port_reinit. >>> >>> Numan Siddique (4): >>> northd: Don't reparse lport's addresses while adding L2_LKUP flows. >>> northd: Refactor chassisresident port checking. >>> Add support for centralize routing for distributed gw ports. >>> northd: Fix potential crash when creating chassisredirect port. >>> >>> Xavier Simonart (1): >>> multinode: Fix test "ovn multinode NAT ...". >> >> No objections from me for the backports. >> >> For the entire series: >> Acked-by: Numan Siddique <num...@ovn.org> >> >> Numan >> >>> >>> NEWS | 3 + >>> controller/physical.c | 4 + >>> northd/northd.c | 504 ++++++++++++++++++++++------------ >>> northd/northd.h | 11 +- >>> ovn-nb.xml | 34 +++ >>> tests/multinode-macros.at | 2 +- >>> tests/multinode.at | 181 +++++++++++++ >>> tests/ovn-northd.at | 553 +++++++++++++++++++++++++++++++++++++- >>> tests/ovn.at | 8 +- >>> 9 files changed, 1110 insertions(+), 190 deletions(-) >>> >>> -- >>> 2.49.0 >>> >> >> > I second that, no objections from my side. > > Acked-by: Ales Musil <amu...@redhat.com> >
Thank you, Ales and Numan! Applied to 24.03. Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
