On 3/13/25 1:43 PM, David Marchand wrote:
> Following a bug report about vhost-user port traffic with a vxlan tunnel
> being dropped, I relooked at the offloading code to see how we could
> switch to the non legacy offload flags mode in the vhost-user libary.
>
> As I dug into this, and with Ilya recent comment (on switching to an
> inner offload API) in mind, I wrote this series.
>
> The result seems promising in terms of code.
> I did no extensive performance testing yet, but I would expect either
> similar performance (or maybe better performance for non offloaded
> traffic, as a number of branches are removed in the flow extraction
> code).
>
>
> Mike recently posted a patch for removing the csum_start/csum_offset
> netdev-linux for which I also had a patch, but since it had some
> implications on the handling of inner checksums, I ended up including my
> version for now.
>
>
> There is still one extra step that is left for a future revision:
> eliminate last if (tunnel) in miniflow_extract().
>
>
> Comments?
Thanks, David.
I think, this is a right approach for moving forward, should be
much easier to understand and maintain in the long term.
For now I applied patches 1 though 6 and the patch 8. I made a
few small adjustments listed below as per review comments from
Mike and my own while looking through the set.
Since there are mainly bug fixes and test improvements, I also
backported them down to 3.3. Having all these tests on LTS will
also allow us to be slightly more confident when backporting
checksum offload fixes in the future.
Patch 7 is also a bug fix and I agree that we should be handling
offload flags properly in the simple match case, I just want to
do a few more additional tests manually, including a performance
check, before applying this one.
List of adjustments:
Patch 3: Re-worded a commit message.
Patch 4: Added coverage counter checks in the test as they were
missing in a couple 'Flag as Rx good.' cases.
Patch 6: Renamed coverage counters removing the 'netdev_' part.
This module is generally named 'native_tnl' in the logs,
we should be using the same shorter name for the counters.
Will follow up on reviews for the rest of the set next week.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
