On 5/13/25 7:23 PM, Dmitry Porokh via dev wrote:
> The idea of this change is to reduce memory allocations/deallocations
> for constant json objects like "uuid", "named_uuid", "map", etc.

Hi, Dmitry.  Thanks for the patch and sorry for delay.

Do you have any performance numbers for this change to show the improvement?

I did actually try a very similar approach last year and didn't see any real
performance improvement, unfortunately, in neither real-world OVN databases
nor synthetic ones.  Tried with databases from ovn-kubernetes setups and with
ovn-heater.

One thing that may have skewed my testing is that I tried this optimization
on top of inlining the short strings and arrays into the json struct:
  https://github.com/igsilya/ovs/commit/5f545e6a0b6cdfed40798efca054e67dafdd66b2
  (I need to clean this up and post someday.)
but I'm not sure.  The impact of these pre-defined short strings seems
negligible in comparison with the rest of memory allocations we do for json
objects.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to