On 3/13/25 1:43 PM, David Marchand wrote: > Packets with L4 partial status for a simple match flow would not get L4 > checksums offloads applied. > > This was not caught in unit tests, because packets from netdev-dummy > (calling miniflow_extract) would get Tx flags set early, before > parse_tcp_flags() got called during packet processing. > > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > lib/flow.c | 33 ++++++++++++++++--- > lib/netdev-dummy.c | 3 +- > lib/netdev-linux.c | 58 --------------------------------- > tests/dpif-netdev.at | 76 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 106 insertions(+), 64 deletions(-)
Thanks, David! I did a round of performance tests with this one and it does impact the packet rate for the simple match rate. But it's below 1% in my synthetic tests and also this is a bug fix in the end, so applied and backported down to 3.3. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
