On Thu, Jun 12, 2025 at 3:05 PM Mark Michelson <mmich...@redhat.com> wrote:
> On 6/11/25 09:54, Dumitru Ceara wrote:
> > On 6/11/25 9:37 AM, Ales Musil via dev wrote:
> >> Handle ACL changes in port group incrementally. The logical switch
> >> ACL changes are already handled, add similar method for port groups
> >> which should prevent lflow recomputes. There is still lflow dependency
> >> on ACL table that results in full lflow recompute. That will be solved
> >> in future commit.
> >>
> >> Signed-off-by: Ales Musil <amu...@redhat.com>
> >> ---
> >
> > Hi Ales,
> >
> >> v4: Rebase on top of latest main.
> >> Add extra check if port group is new/deleted.
> >> v3: Rebase on top of latest main.
> >> v2: Rebase on top of latest main.
> >> ---
> >> northd/en-northd.c | 24 ++++++++++++
> >> northd/en-northd.h | 2 +
> >> northd/inc-proc-northd.c | 2 +
> >> northd/northd.c | 61 ++++++++++++++++++++++++++++++
> >> northd/northd.h | 3 ++
> >> tests/ovn-northd.at | 81
> +++++++++++++++++++++++++++++++++++-----
> >> 6 files changed, 164 insertions(+), 9 deletions(-)
> >>
> >
> >
> >> diff --git a/northd/northd.c b/northd/northd.c
> >> index 2da94e7e1..1490f046e 100644
> >> --- a/northd/northd.c
> >> +++ b/northd/northd.c
> >> @@ -5195,6 +5195,67 @@ fail:
> >> return false;
> >> }
> >>
> >> +static bool
> >> +is_pg_acls_changed(const struct nbrec_port_group *npg) {
> >> +
> >> + return (nbrec_port_group_is_updated(npg, NBREC_PORT_GROUP_COL_ACLS)
> >> + || is_acls_seqno_changed(npg->acls, npg->n_acls));
> >> +}
> >> +
> >> +bool
> >> +northd_handle_pgs_acl_changes(const struct northd_input *ni,
> >> + struct northd_data *nd)
> >> +{
> >> + const struct nbrec_port_group *nb_pg;
> >> + struct northd_tracked_data *trk_data = &nd->trk_data;
> >> +
> >> + NBREC_PORT_GROUP_TABLE_FOR_EACH_TRACKED (nb_pg,
> >> +
> ni->nbrec_port_group_table) {
> >> + if (nbrec_port_group_is_new(nb_pg) ||
> >> + nbrec_port_group_is_deleted(nb_pg)) {
> >> + continue;
> >> + }
> >
> > Nit: I think this could use a comment saying why it's OK to consider
> > created/deleted port groups as EN_HANDLED_UNCHANGED.
> >
> > With that:
> >
> > Acked-by: Dumitru Ceara <dce...@redhat.com>
> >
> > Thanks,
> > Dumitru
> >
>
> Acked-by: Mark Michelson <mmich...@redhat.com>
>
>
Thank you Mark and Dumitru,
I've added the missing comment, went ahead and merged this into main.
Regards,
Ales
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
