On 6/19/25 1:55 PM, Ales Musil via dev wrote: > Add missing sync calls which would lead to flaky tests. > > Signed-off-by: Ales Musil <amu...@redhat.com> > --- > v2: Rebase on top of latest main. > Move one sync call after "wait_for_ports_up". > Remove extra sync call. > ---
Hi Ales, Thanks for v2! > tests/ovn.at | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index b561c69aa..f5ab16db6 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -15943,6 +15943,7 @@ hv1_uuid=$(fetch_column Chassis _uuid name=hv1) > hv2_uuid=$(fetch_column Chassis _uuid name=hv2) > > OVN_POPULATE_ARP > +check ovn-nbctl --wait=hv sync > I think you might have forgotten to take care of the comment I had on this change in v1, that is: > Shouldn't this one be a bit lower, after "wait_for_ports_up"? Just > after the current line we configure options on the "migrator" LSP. > Alternatively, we could add --wait=hv to that lsp-set-options > command. The rest looks good to me, so if you fix this up when pushing the patch feel free to add my ack: Acked-by: Dumitru Ceara <dce...@redhat.com> Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
