On 6/17/25 9:20 AM, David Marchand wrote: > Following a bug report about vhost-user port traffic with a vxlan tunnel > being dropped, I relooked at the offloading code to see how we could > switch to the non legacy offload flags mode in the vhost-user libary. > > As I dug into this, and with Ilya recent comment (on switching to an > inner offload API) in mind, I wrote this series. > > The result seems promising in terms of code. > I did no extensive performance testing yet, but I would expect either > similar performance (or maybe better performance for non offloaded > traffic, as a number of branches are removed in the flow extraction > code). > > > Mike recently posted a patch for removing the csum_start/csum_offset > netdev-linux for which I also had a patch, but since it had some > implications on the handling of inner checksums, I ended up including my > version for now. > > > There is still one extra step that is left for a future revision: > eliminate last if (tunnel) in miniflow_extract().
Yeah, would be nice to get rid of this one somehow as well. But, for now... Thanks, David for the nice re-work/cleanup and Mike for previous reviews! This version even provides a slight performance improvement for the v2v/simple-match/no-offload case, which is good to see. And while I'm pretty sure either implementations (old and new) still have some things to be fixed, I think it should be much easier to navigate the new code structure when the need arises. Applied to main. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
