On 6/19/25 12:29 PM, Eelco Chaudron via dev wrote:
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
> ---
>  utilities/checkpatch.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 566a2bd60..11f79b5d5 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -119,7 +119,8 @@ def open_spell_check_dict():
>                            'tftp', 'timeval', 'trie', 'tso', 'ubsan', 'ukey',
>                            'umask', 'unassociated', 'unixctl', 'uuid'
>                            'virtqueue', 'vms', 'vnet', 'vport', 'vports',
> -                          'vtep', 'wc', 'wget', 'xenserver', 'util']
> +                          'vtep', 'wc', 'wget', 'xenserver', 'util',
> +                          'enablement', 'ifdef', 'tnl', 'apis']
>  
>          global spell_check_dict
>  

At some point, I think, we should re-define the whole thing as a large
multi-line string like this:

extra_keywords_str = '''
word1
word2
...
wordZ
'''

extra_keywords = extra_keywords_str.strip().splitlines()

And have the word list sorted.  We have a few duplicates in there already.

This way it will be easier to modify the list and to spot duplicates.  The
original formation was fine when it fit a single screen, so all the words
were visible at once, but we're reaching the point where it's not the case.

Alternative may be to store the list in a separate text fine, but we'll
need a way to find it as checkpatch is normally executed from a source
tree.  Could use something like:
   Path(__file__).resolve().parent + "/extra_keywords.txt"

But that's a journey for another day. :)

For the current patch:

Acked-by: Ilya Maximets <i.maxim...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to