On 6/20/25 10:34 AM, Eelco Chaudron wrote:
>
>
> On 18 Jun 2025, at 20:28, Ilya Maximets wrote:
>
>> _Server database is not managed by the user and needed mostly for IDL
>> itself to see changes in the schema or cluster leadership. However,
>> we're currently delivering notifications about changes in that database
>> confusing the application (the application didn't subscribe to this
>> database) and also we're increasing the change_seqno potentially
>> returning true for has_ever_connected() call even if we didn't really
>> get any real data yet or even connected to the right database.
>>
>> In the tests these notifications can be seen as two events at the
>> beginning of every test with the notification enabled:
>>
>> 000: event:create, row={}, uuid=<0>, updates=None
>> 000: event:create, row={}, uuid=<1>, updates=None
>>
>> Tests only print the 'simple' table, so the content is omitted, but
>> the data is still there and the empty events are printed out.
>>
>> We should not notify the application nor touch the change_seqno.
>> Tests updated accordingly. Unfortunately, removing first two lines
>> from a test changes the numbers generated by the UUID filter, so the
>> rest of the test needs adjustments as well.
>>
>> Fixes: c39751e44539 ("python: Monitor Database table to manage lifecycle of
>> IDL client.")
>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>
> Thanks, Ilya, this makes perfect sense. The patch looks good to me.
>
> Acked-by: Eelco Chaudron <echau...@redhat.com>
Thanks! Applied and backported down to 3.2.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
