On 6/26/25 9:18 PM, Dumitru Ceara via dev wrote: > From: Igal Tsoiref <itsoi...@redhat.com> > > - Adds the --ovn-controller-system-id=STRING option to ovn-ctl, > allowing users to specify the chassis name (system-id) for > ovn-controller via the -n flag. > - The option is handled automatically by the generic option parser > and is documented in the help output, aligned with other > --ovn-* options. > - This enables running multiple ovn-controllers on the same host > by assigning each a unique system-id. > > Submitted-at: https://github.com/ovn-org/ovn/pull/280 > Signed-off-by: Igal Tsoiref <itsoi...@redhat.com> > ---
Hi Igal, Thanks for your contribution! > NOTE (Dumitru): > When cherry picking this from the ovn-org/ovn PR > https://github.com/ovn-org/ovn/pull/280 I just reformatted the > commit message so that it fits in < 72 columns. > --- > utilities/ovn-ctl | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl > index 48cfc3214b..36312e1ce5 100755 > --- a/utilities/ovn-ctl > +++ b/utilities/ovn-ctl > @@ -663,6 +663,9 @@ start_controller () { > if test X"$OVN_CONTROLLER_SSL_CIPHERSUITES" != X; then > set "$@" --ssl-ciphersuites=$OVN_CONTROLLER_SSL_CIPHERSUITES > fi > + if test X"$OVN_CONTROLLER_SYSTEM_ID" != X; then > + set "$@" -n "$OVN_CONTROLLER_SYSTEM_ID" > + fi > > [ "$OVN_USER" != "" ] && set "$@" --user "$OVN_USER" > > @@ -1014,6 +1017,8 @@ set_defaults () { > DB_SB_RELAY_CONFIG_FILE= > > DB_CLUSTER_SCHEMA_UPGRADE="yes" > + > + OVN_CONTROLLER_SYSTEM_ID="" > } > > set_option () { > @@ -1133,6 +1138,7 @@ Options: > --ovn-northd-n-threads=N_THREADS ovn northd process number of threads > (default: $OVN_NORTHD_N_THREADS) > --ovn-nb-log=STRING ovn NB ovsdb-server processes logging > params (default: $OVN_NB_LOG) > --ovn-sb-log=STRING ovn SB ovsdb-server processes logging > params (default: $OVN_SB_LOG) > + --ovn-controller-system-id=STRING set chassis name (system-id) > for ovn-controller (passed as -n) I changed this slightly, reducing to two spaces before the description string. > --ovn-ic-priority=NICE set ovn-ic's niceness (default: > $OVN_IC_PRIORITY) > --ovn-ic-wrapper=WRAPPER run with a wrapper like valgrind for debugging > --ovn-ic-ssl-key=KEY OVN IC SSL/TLS private key file Then I pushed the patch to the main branch. I also added you to the AUTHORS.rst list. Best regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
