When backporting 68c83ffbb960 ("controller: Prevent assert with BGP
when SB is read only.") which added the new route_exchange handler for
en_sb_ro (SB readonly state) changes I messed up the return values.
On the main branch I-P handlers return EN_UNHANDLED if they
successfully processed input changes and EN_HANDLED_UNCHANGED
otherwise.
On older branches (25.03 included) they should return "true" if they
successfully processed input changes and "false" otherwise. I mixed
these up and this commit addresses that.
Fixes: 3e53345ab689 ("controller: Prevent assert with BGP when SB is read
only.")
Signed-off-by: Dumitru Ceara <[email protected]>
---
controller/ovn-controller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
index ca36a3c05c..9a21069e7c 100644
--- a/controller/ovn-controller.c
+++ b/controller/ovn-controller.c
@@ -5333,10 +5333,10 @@ route_exchange_sb_ro_handler(struct engine_node *node
OVS_UNUSED, void *data)
{
struct ed_type_route_exchange *re = data;
if (re->sb_changes_pending) {
- return true;
+ return false;
}
- return false;
+ return true;
}
--
2.49.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
