On 8/15/25 8:56 PM, Burnin Ivan wrote:
> Python versions below 3.7 do not correctly read the AUTHORS.rst file unless
> the LC_CTYPE environment variable is set to UTF-8. This causes unit test
> number 24:checkpatch - AUTHORS.rst existence to fail with
> UnicodeDecodeError
Hi, Ivan. Thanks for the patch!
Python 3.7 is a minimal supported version since OVS 3.5, and this
test only exists in 3.5+. You should have more tests failures if
you're using 3.6 or older, in fact, you should not be able to build
OVS with this version of Python.
See the following commit:
3131588e1e1d ("python: Require Python 3.7 for ssl.TLSVersion.")
Or does it fail with Python 3.7?
Best regards, Ilya Maximets.
>
> Signed-off-by: Ivan Burnin <iburnin@k2.cloud>
> ---
> utilities/checkpatch.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 28d0977eb..52bb8196b 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -841,7 +841,7 @@ def do_authors_exist(authors):
> missing_authors = []
>
>
> try:
> - with open(get_top_directory() + "/AUTHORS.rst", "r") as file:
> + with open(get_top_directory() + "/AUTHORS.rst", "r", encoding="utf-8") as
> file:
> file_content = file.read()
> for author in authors:
> m = re.search(r'<(.*?)>', author)
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
