On 8/19/25 10:37 AM, Rukomoinikova Aleksandra wrote:
> *Hi Dumitru!*
>
Hi Alexandra,
Thanks for the patch!
> I’ve sent the required patch. Just wanted to clarify: I didn’t add
> explicit tests for the availability zone bc:
>
> 1.
>
> *Northd’s logic already prevents it* – The code ensures users can’t
> create a remote service monitor with a null |az| name (this is
> covered by an existing test: ip_port_mappings validation in
> ovn-northd tests).
>
> 2.
>
> Even if the |az| name is somehow removed from the service monitor
> options later, northd will restore it.
>
> Let me know if you’d like any adjustments! thanks for the review again!
>
I think the above is reasonable.
>
> On 19.08.2025 11:30, Alexandra Rukomoinikova wrote:
We should add a Fixes tag here:
Fixes: f40a5c3c803a ("ic: Implement cross-AZ service monitor synchronization.")
>> Signed-off-by: Alexandra Rukomoinikova <arukomoinikova@k2.cloud>
>> ---
The change looks good to me, thanks! I added the "Fixes" tag and pushed
this to main and 25.09.
Regards,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
