On Tue, Aug 26, 2025 at 8:35 AM Eelco Chaudron via dev <
ovs-dev@openvswitch.org> wrote:
> Fixing this Coverity error by adding an ovs_assert() for the
> case not allowed.
>
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
> ---
> ovsdb/monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
> index c3bfae3d2..8b1923e29 100644
> --- a/ovsdb/monitor.c
> +++ b/ovsdb/monitor.c
> @@ -1022,6 +1022,7 @@ ovsdb_monitor_compose_row_update(
> &c->column->type));
> }
> if (type & (OJMS_INITIAL | OJMS_INSERT | OJMS_MODIFY)) {
> + ovs_assert(row->new);
>
This isn't bad persay, but couldn't we just change the logic in
ovsdb_monitor_row_update_type?
-M
> json_object_put(new_json, c->column->name,
> ovsdb_datum_to_json(&row->new[i],
> &c->column->type));
> --
> 2.50.1
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
