On 11/09/2025 14:33, Kevin Traynor wrote:
> rte_eal_init() arg '-c' is deprecated in DPDK 25.07.
>
> So we will need to replace converting dpdk-lcore-mask to -c at least for
> use of DPDK 25.11. In fact, we don't need to wait for DPDK 25.11,
> because we can do this now by using '--lcores' instead of '-c'.
>
> This also adds compatability for using a core greater than the max
> lcore value, similar to commit:
> fe53b478f86e ("dpdk: Fix main lcore on systems with many cores.")
>
> Masks with invalid core numbers and total number of cores are also handled
> more gracefully, as they are not blindly passed to DPDK.
>
> The first 2 patches are minor cleanups:
>
> - vswitch.xml is updated as the old dpdk-lcore-mask description was
> a bit misleading.
>
> - Some of the added default handling was not used, so we can remove it.
>
> v3:
> Reworked for Eelco and Ilya's comments.
> - 1/3: updated vswitch.xml description
> - 3/3: used ds_put_format. Updated log. Moved test macro.
>
> v2:
> Reworked for David's comments.
> - 2/3: added this cleanup
> - 3/3: reworked to simplify and reuse existing mask parsing. Changed test
> cases.
>
> Kevin Traynor (3):
> vswitch.xml: Update docs for dpdk-lcore-mask.
> dpdk: Clean up dpdk option map.
> dpdk: Convert dpdk-lcore-mask to DPDK lcore args.
>
> lib/dpdk.c | 83 +++++++++++++++++++++++++++++++++++++++-----
> tests/ovs-macros.at | 16 +++++++++
> tests/pmd.at | 15 --------
> tests/system-dpdk.at | 72 ++++++++++++++++++++++++++++++++++++++
> vswitchd/vswitch.xml | 19 +++++++---
> 5 files changed, 176 insertions(+), 29 deletions(-)
>
Thanks David, Eelco and Ilya. I cleaned up for those minor comments on
v3 and applied to main branch.
regards,
Kevin.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
