Hi Dumitru,
That’s a good point. This has been addressed in v9.
Thanks,
Sragdhara
From: Dumitru Ceara <dce...@redhat.com>
Date: Friday, August 29, 2025 at 12:26 PM
To: Sragdhara Datta Chaudhuri <sragdha.chau...@nutanix.com>,
ovs-dev@openvswitch.org <ovs-dev@openvswitch.org>
Cc: Numan Siddique <num...@ovn.org>
Subject: Re: [ovs-dev] [PATCH OVN v8 5/5] northd, controller, tests: Network
Function Health monitoring.
!-------------------------------------------------------------------|
CAUTION: External Email
|-------------------------------------------------------------------!
Hi Sragdhara,
>> diff --git a/ovn-ic-sb.ovsschema b/ovn-ic-sb.ovsschema
>> index 34b5457bb..6d062bf61 100644
>> --- a/ovn-ic-sb.ovsschema
>> +++ b/ovn-ic-sb.ovsschema
>> @@ -1,7 +1,7 @@
>> {
>> "name": "OVN_IC_Southbound",
>> - "version": "2.2.0",
>> - "cksum": "2294868959 8438",
>> + "version": "2.2.1",
>
> This should be 2.3.0 instead. .z version is incremented on cosmetic
> changes, we're doing more than that, we're adding a column.
>
>> + "cksum": "3845118402 8592",
>> "tables": {
>> "IC_SB_Global": {
>> "columns": {
>> @@ -148,6 +148,9 @@
>> "maxRows": 1},
>> "Service_Monitor": {
>> "columns": {
>> + "type": {"type": {"key": {
>> + "type": "string",
>> + "enum": ["set", ["load-balancer"]]}}},
>
> Is this change backwards compatible? What if we upgrade from a setup
> with a IC_SB that already had a Service_Monitor configured?
>
It looks like this will create upgrade issues, please see a similar bug
report here:
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2025-2DAugust_425789.html&d=DwICaQ&c=s883GpUCOChKOHiocYtGcg&r=uXnTjPDrt8WYa8nbZqANTqL0TyzFTTKpPHphGFPgvBw&m=aGuXFtOmLlkBYdfatCspKRMZXBBbjwSQmi1OIuMS_GLM_hAX4PIwYFIywngUB3F2&s=uGVw7WpEVoJ7L6MQnEtYBe8ZGfo5CkhIFIMIlM3LZf0&e=
>> "ip": {"type": "string"},
>> "protocol": {
>> "type": {"key": {"type": "string",
>> diff --git a/ovn-ic-sb.xml b/ovn-ic-sb.xml
>> index 35dc1f509..924aaac5f 100644
>> --- a/ovn-ic-sb.xml
>> +++ b/ovn-ic-sb.xml
>> @@ -692,6 +692,10 @@
>> </table>
>>
>> <table name="Service_Monitor">
>> + <column name="type">
>> + The type of the service. Only the value "load-balancer" is supported.
>> + </column>
>> +
>> <column name="ip">
>> IP of the service to be monitored. Copy from SBDB record.
>> </column>
>> diff --git a/ovn-nb.xml b/ovn-nb.xml
>> index 702921850..f87f464eb 100644
>> --- a/ovn-nb.xml
>> +++ b/ovn-nb.xml
>> @@ -441,6 +441,38 @@
>> </p>
>> </column>
>>
>> + <group title="Options for services health check confguration">
>> + <p>
>> + These options are used when health configuration is enabled for
>> + <ref table="Load_Balancer" db="OVN_Northbound"/>
>> + and <ref table="Network_Function" db="OVN_Northbound"/> services.
>> + </p>
>> +
>> + <column name="options" key="svc_monitor_mac">
>> + MAC Address used as the Ethernet source in health check probes.
>> + If unspecified, a MAC address is automatically generated.
>> + </column>
>> +
>> + <column name="options" key="svc_monitor_mac_dst">
>> + MAC Address used as the Ethernet destination in health check
>> probes.
>> + If unspecified, a MAC address is automatically generated.
>> + This applies only to Network Function health check probes deployed
>> + in inline mode.
>> + </column>
>> +
>> + <column name="options" key="svc_monitor_ip">
>> + IP Address (IPv4 or IPv6) used as the source in health check
>> probes.
>> + This applies only to Network Function health check probes deployed
>> + in inline mode.
>> + </column>
>> +
>> + <column name="options" key="svc_monitor_ip_dst">
>> + IP Address (IPv4 or IPv6) used as the destination in health check
>> + probes. This applies only to Network Function health check probes
>> + deployed in inline mode.
>> + </column>
>> + </group>
>> +
>> <group title="Options for configuring interconnection route
>> advertisement">
>> <p>
>> These options control how routes are advertised between OVN
>> diff --git a/ovn-sb.ovsschema b/ovn-sb.ovsschema
>> index f64cb99dd..a2672d73f 100644
>> --- a/ovn-sb.ovsschema
>> +++ b/ovn-sb.ovsschema
>> @@ -1,7 +1,7 @@
>> {
>> "name": "OVN_Southbound",
>> - "version": "21.4.0",
>> - "cksum": "812831561 35225",
>> + "version": "21.4.1",
>
> This should be 21.5.0
>
>> + "cksum": "3285280742 35552",
>> "tables": {
>> "SB_Global": {
>> "columns": {
>> @@ -509,14 +509,20 @@
>> "isRoot": true},
>> "Service_Monitor": {
>> "columns": {
>> + "type": {"type": {"key": {
>> + "type": "string",
>> + "enum": ["set", ["load-balancer",
>> + "network-function"]]}}},
>
> Is this change backwards compatible? What if we upgrade from a setup
> with a SB that already had a Service_Monitor configured?
>
Same here. So we probably have to allow empty string values.
Regards,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
