On 10/7/25 12:41 PM, Ales Musil via dev wrote: > On Tue, Oct 7, 2025 at 8:27 AM Ales Musil <[email protected]> wrote: > >> Add a way to assert IDL txn as read only, that is useful in cases when >> we want to ensure that the program doesn't write anything into the >> txn. It is done via assert because this is considered a bug which >> should be fixed in the IDL caller. >> >> Acked-by: Dumitru Ceara <[email protected]> >> Signed-off-by: Ales Musil <[email protected]> >> --- >> v3: Add Mike's ack. >> Address comments from Ilya: >> - Adjust the line wraps and indentation of tests. >> - Make sure we skip the test if NDEBUG is defined. >> >> v2: Add Dumitru's ack. >> Adjust the ovsdb_idl_txn_assert_read_only() comment. >> Address some small nits. >> --- >> > > I have realized that this version will also crash on indexed rows which > shouldn't happen, > I'll send v4 that will fix that.
As discussed on v4, the index row checks should not be needed. I added a small NEWS entry (since this change is for external consumption mostly) and applied this change to main. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
