Hi Dumitru, Thanks for fixing this. Acked-by: Naveen Yerramneni <[email protected]>
Thanks, Naveen > On 7 Oct 2025, at 5:00 PM, Dumitru Ceara <[email protected]> wrote: > > !-------------------------------------------------------------------| > CAUTION: External Email > > |-------------------------------------------------------------------! > > Found by coverity: > *** CID 490436: Control flow issues (DEADCODE) > /controller/pinctrl.c: 8459 in pinctrl_handle_svc_check() > 8453 "IP datagram"); > 8454 return; > 8455 } > 8456 } > 8457 > 8458 if (!orig_uh) { >>>> CID 490436: Control flow issues (DEADCODE) >>>> Execution cannot reach this statement: "static struct vlog_rate_lim...". > 8459 static struct vlog_rate_limit rl = > VLOG_RATE_LIMIT_INIT(1, 5); > 8460 VLOG_WARN_RL(&rl, "UDP header not found in the original > " > 8461 "IP datagram"); > 8462 return; > 8463 } > > Fixes: b42edf4a43b3 ("northd, controller, tests: Network Function Health > monitoring.") > Signed-off-by: Dumitru Ceara <[email protected]> > --- > controller/pinctrl.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index 77cb0c6847..e3f97af12b 100644 > --- a/controller/pinctrl.c > +++ b/controller/pinctrl.c > @@ -8451,13 +8451,6 @@ pinctrl_handle_svc_check(struct rconn *swconn, const > struct flow *ip_flow, > } > } > > - if (!orig_uh) { > - static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); > - VLOG_WARN_RL(&rl, "UDP header not found in the original " > - "IP datagram"); > - return; > - } > - > uint32_t hash = > hash_bytes(&ip_addr, sizeof ip_addr, > hash_3words(dp_key, port_key, > ntohs(orig_uh->udp_dst))); > -- > 2.51.0 > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
