Hi Eelco, I've sent v2. I fixed some issues and ran the tests on my local github. I see that one test still fails, but sending the same patches again it may pass. See test #9 for linux gcc check check-dpdk dpdk, linux clang check check-dpdk dpdk. The clang test failed on run #1 and passed on run #2. Run #1: https://github.com/elibritstein/OVS/actions/runs/18520078990/job/52777947900 Run #2: https://github.com/elibritstein/OVS/actions/runs/18532168184/job/52817622938 I tried this test on my local setup, and it also passed. I suspect something might be wrong there.
Please review the changes to see the approach. If it is acceptable besides the test, I'll invest more time to get to the bottom of it. Thanks, Eli >-----Original Message----- >From: Eelco Chaudron <[email protected]> >Sent: Tuesday, 14 October 2025 12:09 >To: Eli Britstein <[email protected]> >Cc: [email protected]; Gaetan Rivet <[email protected]>; Ilya >Maximets <[email protected]>; Maor Dickman <[email protected]> >Subject: Re: [PATCH v1 0/3] Generic libraries initialization/status > >External email: Use caution opening links or attachments > > >On 13 Oct 2025, at 12:39, Eli Britstein wrote: > >> Currently dpdk is a special case and has dedicated calls from the >> bridge module and entries in OVS schema. Also, dpdk netdev >> registration is done not the way of other netdev classes. >> Generalize it with set_other_config/status API, as well as a >> preparation for more libraries in the future. > >Hi Eli, > >Thanks for sending these patches! I haven’t reviewed the code itself yet, but I >noticed that the second patch is failing a DPDK test and the third one doesn’t >compile. It would be best to post a new revision once all tests pass, so we can >focus on reviewing the changes themselves. > >To make things a bit easier, I’d recommend enabling GitHub Actions on your >fork. That way, you can automatically verify that your patches build and pass >the tests before sending them upstream. > >Cheers, >Eelco > > >> Eli Britstein (3): >> netdev: Introduce class set_other_config/status API. >> netdev-dpdk: Generic class registration. >> vswitch: Remove dedicated dpdk properties from schema. >> >> lib/dpdk.c | 18 +++++--- >> lib/netdev-dpdk.c | 86 +++++++++++++++++++++++++------------- >> lib/netdev-dpdk.h | 1 - >> lib/netdev-provider.h | 17 ++++++++ >> lib/netdev.c | 35 ++++++++++++++++ >> lib/netdev.h | 3 ++ >> vswitchd/bridge.c | 8 ++-- >> vswitchd/vswitch.ovsschema | 12 +++--- >> vswitchd/vswitch.xml | 15 ++----- >> 9 files changed, 136 insertions(+), 59 deletions(-) >> >> -- >> 2.34.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
