On 9/29/25 10:35 AM, Ales Musil wrote: > On Sat, Sep 27, 2025 at 12:20 AM Dumitru Ceara <[email protected]> wrote: > >> ADD_VETH() was incorrectly called in the test, its signature is: >> ADD_VETH([port], [namespace], [ovs-br], [ip_addr] [mac_addr], [gateway], >> [ip_addr_flags] [ip6_addr] [gateway6]) >> >> The [ip_addr] and [gateway] arguments were swapped. While this doesn't >> affect the test outcome because there's no actual traffic flowing, it's >> just confusing and will break once we try to test with traffic. >> >> Fixes: 6b66d634d781 ("northd: Add an option to specify EVPN vni in logical >> switches.") >> Signed-off-by: Dumitru Ceara <[email protected]> >> --- >> tests/system-ovn.at | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/system-ovn.at b/tests/system-ovn.at >> index 3a321f84a4..85e432e75d 100644 >> --- a/tests/system-ovn.at >> +++ b/tests/system-ovn.at >> @@ -18296,12 +18296,12 @@ check ovn-nbctl >> \ >> -- lsp-set-options ln_port network_name=phynet >> >> ADD_NAMESPACES(workload1) >> -ADD_VETH(workload1, workload1, br-int, "172.16.1.1/24", >> "f0:00:0f:16:01:10", \ >> - "172.16.1.10") >> +ADD_VETH(workload1, workload1, br-int, "172.16.1.10/24", >> "f0:00:0f:16:01:10", \ >> + "172.16.1.1") >> >> ADD_NAMESPACES(workload2) >> -ADD_VETH(workload2, workload2, br-int, "172.16.1.1/24", >> "f0:00:0f:16:01:20", \ >> - "172.16.1.20") >> +ADD_VETH(workload2, workload2, br-int, "172.16.1.20/24", >> "f0:00:0f:16:01:20", \ >> + "172.16.1.1") >> >> OVN_POPULATE_ARP >> check ovn-nbctl --wait=hv sync >> -- >> 2.51.0 >> >> > Look good to me, thanks. > Acked-by: Ales Musil <[email protected]> >
Hi Ales, Thanks for the review! Applied to main and 25.09. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
