If netlink transaction returns malformed or otherwise not parsable
reply, it should be freed, as callers will not do that on failure.
Found while reading the code.
Fixes: 80738e5f93a7 ("dpif-netlink: Add meter support.")
Signed-off-by: Ilya Maximets <[email protected]>
---
lib/dpif-netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 2b33d0fa6..c327296ea 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -4083,6 +4083,7 @@ dpif_netlink_meter_transact(struct ofpbuf *request,
struct ofpbuf **replyp,
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
VLOG_DBG_RL(&rl,
"Kernel module response to meter tranaction is invalid");
+ ofpbuf_delete(*replyp);
return EINVAL;
}
return 0;
--
2.51.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev