On 11/3/25 11:34 AM, Nadia Pinaeva wrote: > Thank you for the update, I find this version more clear!
Hi Nadia, Thanks for reviewing it! > Nit: >> + tunnel keys for the <code>Transit Router</code> itself and > the router >> + ports keys needs to match in all AZs e.g. TR in AZ1 and AZ2 > need to > Reads as "tunnel keys for ... the router ports keys", so maybe we > should replace > "router ports keys" with "router ports"? You're right, that's better. I did that in v2 (along with the small change I mentioned below about non-transit router ports): https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/ Regards, Dumitru > ------------------------------------------------------------------------ > *From:* Dumitru Ceara <[email protected]> > *Sent:* Thursday, October 30, 2025 16:03 > *To:* [email protected] <[email protected]> > *Cc:* Nadia Pinaeva <[email protected]> > *Subject:* Re: [ovs-dev] [PATCH ovn] ovn-nb: Clarify requirements for > transit router ports in our docs. > > External email: Use caution opening links or attachments > > > On 10/30/25 3:51 PM, Dumitru Ceara via dev wrote: >> It was a bit unclear whether non-transit router port keys need to be >> synced across AZs or not. >> >> Reported-by: Nadia Pinaeva <[email protected]> >> Signed-off-by: Dumitru Ceara <[email protected]> >> --- >> ovn-nb.xml | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/ovn-nb.xml b/ovn-nb.xml >> index 36d7accaf9..31761cb9e0 100644 >> --- a/ovn-nb.xml >> +++ b/ovn-nb.xml >> @@ -3481,10 +3481,13 @@ or >> >> <p> >> In order for the <code>Transit Router</code> to work properly all >>the >> - tunnel keys for the <code>Transit Router</code> itself and the >> remote >> - ports keys needs to match in all AZs e.g. TR in AZ1 and AZ2 needs >> to >> - have the same tunnel key. Remote port for AZ2 in AZ1 needs to have >> the >> - same tunnel key as local port in AZ2 and vice vers. >> + tunnel keys for the <code>Transit Router</code> itself and the >> router >> + ports keys needs to match in all AZs e.g. TR in AZ1 and AZ2 need to >> + have the same tunnel key. Remote ports for AZ2 in AZ1 need to have >> the >> + same tunnel key as local ports in AZ2 and vice versa. It's also >> + possible that the router has fully distributed router ports, without > > After posting the patch I realized that "fully distributed router ports" > is confusing. They could be DGPs (bound to a given chassis) as well. > > I'll probably change this to "non-transit ports" in v2 but I'll wait for > more reviews before doing that. > >> + <code>options:requested-chassis</code> set; their keys also need to >> + match in all AZs. >> </p> >> >> <p> > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
