Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#163 FILE: br-controller/ovn-br-controller.8.xml:4:
<p>ovn-br-controller -- Open Virtual Network local OVS bridge controller</p>
WARNING: Line is 86 characters long (recommended limit is 79)
#175 FILE: br-controller/ovn-br-controller.8.xml:16:
bridges. It connects up to the OVN bridge database (see
<code>ovn-br</code>(5))
WARNING: Line is 83 characters long (recommended limit is 79)
#178 FILE: br-controller/ovn-br-controller.8.xml:19:
to <code>ovs-vswitchd</code>(8) via OpenFlow.
<code>ovn-br-controller</code>
WARNING: Line is 88 characters long (recommended limit is 79)
#179 FILE: br-controller/ovn-br-controller.8.xml:20:
processes and converts the OVN Logical flows configured in the OVN bridge
database
WARNING: Line is 89 characters long (recommended limit is 79)
#180 FILE: br-controller/ovn-br-controller.8.xml:21:
for the Open vSwitch bridges to OpenFlow rules and programs these flow
rules to the
WARNING: Line is 81 characters long (recommended limit is 79)
#604 FILE: ovn-br.xml:7:
the contents of the database. The <code>ovn-bridge-controller</code>
program
WARNING: Line is 82 characters long (recommended limit is 79)
#684 FILE: ovn-br.xml:87:
<dt><code>ssl:<var>host</var></code>[<code>:<var>port</var></code>]</dt>
WARNING: Line is 82 characters long (recommended limit is 79)
#703 FILE: ovn-br.xml:106:
<dt><code>tcp:<var>host</var></code>[<code>:<var>port</var></code>]</dt>
WARNING: Line is 84 characters long (recommended limit is 79)
#709 FILE: ovn-br.xml:112:
address, wrap it in square brackets, e.g.
<code>tcp:[::1]:6640</code>.
WARNING: Line is 85 characters long (recommended limit is 79)
#715 FILE: ovn-br.xml:118:
<dt><code>pssl:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>
WARNING: Line is 85 characters long (recommended limit is 79)
#740 FILE: ovn-br.xml:143:
<dt><code>ptcp:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>
WARNING: Line is 110 characters long (recommended limit is 79)
#815 FILE: ovn-br.xml:218:
type='{"type": "string", "enum": ["set", ["VOID", "BACKOFF",
"CONNECTING", "ACTIVE", "IDLE"]]}'>
WARNING: Line is 81 characters long (recommended limit is 79)
#1121 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:3:
# To customize the ovn-br-controller service, you may create a configuration
file
WARNING: Line is 85 characters long (recommended limit is 79)
#1122 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:4:
# in the /etc/systemd/system/ovn-br-controller.d/ directory. For example, to
specify
WARNING: Line is 86 characters long (recommended limit is 79)
#1123 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:5:
# additional options to be passed to the "ovn-ctl start_ovnbr_controller"
command, you
WARNING: Line is 102 characters long (recommended limit is 79)
#1128 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:10:
# Environment="OVNBR_CONTROLLER_OPTS=--ovnbr-controller-log=-vconsole:emer
-vsyslog:err -vfile:info"
WARNING: Line is 97 characters long (recommended limit is 79)
#1130 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:12:
# Alternatively, you may specify environment variables in the file
/etc/sysconfig/ovn-controller:
WARNING: Line is 90 characters long (recommended limit is 79)
#1132 FILE: rhel/usr_lib_systemd_system_ovn-br-controller.service:14:
# OVNBR_CONTROLLER_OPTS="--ovnbr-controller-log=-vconsole:emer -vsyslog:err
-vfile:info"
WARNING: Line is 81 characters long (recommended limit is 79)
#1164 FILE: rhel/usr_lib_systemd_system_ovn-br-db.service:5:
# additional options to be passed to the "ovn-ctl start_ovnbr_ovsdb" command,
you
WARNING: Line is 92 characters long (recommended limit is 79)
#1171 FILE: rhel/usr_lib_systemd_system_ovn-br-db.service:12:
# Alternatively, you may specify environment variables in the file
/etc/sysconfig/ovn-br-db:
WARNING: Line is 135 characters long (recommended limit is 79)
#1240 FILE: tutorial/ovn-sandbox:443:
PATH=$builddir/controller:$builddir/controller-vtep:$builddir/northd:$builddir/ic:$builddir/utilities:$builddir/br-controller:$PATH
WARNING: Line lacks whitespace around operator
#1782 FILE: utilities/ovn-brctl.c:491:
lflow-list [BRIDGE] [LFLOW...] list logical flows for BRIDGE\n\
WARNING: Line lacks whitespace around operator
#1783 FILE: utilities/ovn-brctl.c:492:
dump-flows [BRIDGE] [LFLOW...] alias for lflow-list\n\
Lines checked: 1867, Warnings: 23, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
