Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 103 characters long (recommended limit is 79)
#90 FILE: utilities/ovn-ctl:769:
OVS_RUNDIR=${OVS_RUNDIR} start_ovn_daemon "$OVN_CONTROLLER_PRIORITY"
"$OVN_CONTROLLER_WRAPPER" "$@"
WARNING: Line is 81 characters long (recommended limit is 79)
#176 FILE: utilities/ovn-ctl:1199:
start_ovnbr_ovsdb start ovn bridge controller db ovsdb-server
process
WARNING: Line is 80 characters long (recommended limit is 79)
#178 FILE: utilities/ovn-ctl:1201:
stop_ovnbr_ovsdb stop ovn bridge controller db ovsdb-server process
WARNING: Line is 83 characters long (recommended limit is 79)
#180 FILE: utilities/ovn-ctl:1203:
restart_ovnbr_ovsdb restart ovn bridge controller db ovsdb-server
process
WARNING: Line is 84 characters long (recommended limit is 79)
#182 FILE: utilities/ovn-ctl:1205:
status_ovnbr_ovsdb status ovn bridge controller db ovsdb-server
processes
WARNING: Line is 108 characters long (recommended limit is 79)
#192 FILE: utilities/ovn-ctl:1285:
--ovn-br-controller-priority=NICE set ovn-br-controller's niceness
(default: $OVN_CONTROLLER_PRIORITY)
WARNING: Line is 86 characters long (recommended limit is 79)
#193 FILE: utilities/ovn-ctl:1286:
--ovn-br-controller-wrapper=WRAPPER run with a wrapper like valgrind for
debugging
WARNING: Line is 80 characters long (recommended limit is 79)
#194 FILE: utilities/ovn-ctl:1287:
--ovn-br-controller-ssl-key=KEY OVN Bridge Controller SSL/TLS private key file
WARNING: Line is 82 characters long (recommended limit is 79)
#195 FILE: utilities/ovn-ctl:1288:
--ovn-br-controller-ssl-cert=CERT OVN Bridge Controller SSL/TLS certificate
file
WARNING: Line is 88 characters long (recommended limit is 79)
#196 FILE: utilities/ovn-ctl:1289:
--ovn-br-controller-ssl-ca-cert=CERT OVN Bridge Controller SSL/TLS CA
certificate file
WARNING: Line is 111 characters long (recommended limit is 79)
#197 FILE: utilities/ovn-ctl:1290:
--ovn-br-controller-ssl-bootstrap-ca-cert=CERT Bootstrapped OVN Bridge
Controller SSL/TLS CA certificate file
WARNING: Line is 85 characters long (recommended limit is 79)
#198 FILE: utilities/ovn-ctl:1291:
--ovn-br-controller-ssl-protocols=PROTOCOLS OVN Bridge Controller SSL/TLS
protocols
WARNING: Line is 83 characters long (recommended limit is 79)
#199 FILE: utilities/ovn-ctl:1292:
--ovn-br-controller-ssl-ciphers=CIPHERS OVN Bridge Controller SSL/TLS cipher
list
WARNING: Line is 99 characters long (recommended limit is 79)
#200 FILE: utilities/ovn-ctl:1293:
--ovn-br-controller-ssl-ciphersuites=CIPHERSUITES OVN Bridge Controller
TLSv1.3+ ciphersuite list
WARNING: Line is 83 characters long (recommended limit is 79)
#203 FILE: utilities/ovn-ctl:1296:
--ovn-br-db-ssl-ca-cert=CERT OVN Bridge Controller DB SSL/TLS CA certificate
file
WARNING: Line is 80 characters long (recommended limit is 79)
#204 FILE: utilities/ovn-ctl:1297:
--ovn-br-db-ssl-protocols=PROTOCOLS OVN Bridge Controller DB SSL/TLS protocols
WARNING: Line is 94 characters long (recommended limit is 79)
#206 FILE: utilities/ovn-ctl:1299:
--ovn-br-db-ssl-ciphersuites=CIPHERSUITES OVN Bridge Controller DB TLSv1.3+
ciphersuite list
WARNING: Line is 108 characters long (recommended limit is 79)
#207 FILE: utilities/ovn-ctl:1300:
--ovn-br-controller-log=STRING ovn controller process logging params
(default: $OVN_CONTROLLER_LOG)
WARNING: Line is 109 characters long (recommended limit is 79)
#208 FILE: utilities/ovn-ctl:1301:
--ovn-br-db-log=STRING ovn brdb ovsdb-server processes logging
params (default: $OVN_BR_DB_LOG)
WARNING: Line is 83 characters long (recommended limit is 79)
#217 FILE: utilities/ovn-ctl:1435:
--db-ovnbr-sock=SOCKET OVN_Bridge_Controller db socket (default:
$DB_OVNBR_SOCK)
WARNING: Line is 81 characters long (recommended limit is 79)
#218 FILE: utilities/ovn-ctl:1436:
--db-ovnbr-file=FILE OVN_Bridge_Controller db file (default:
$DB_OVNBR_FILE)
WARNING: Line is 87 characters long (recommended limit is 79)
#219 FILE: utilities/ovn-ctl:1437:
--db-ovnbr-pidfile=FILE OVN_Bridge_Controller db pidfile (default:
$DB_OVNBR_PIDFILE)
WARNING: Line is 83 characters long (recommended limit is 79)
#220 FILE: utilities/ovn-ctl:1438:
--db-ovnbr-schema=FILE OVN_Bridge_Controller db file (default:
$DB_OVNBR_SCHEMA)
WARNING: Line is 89 characters long (recommended limit is 79)
#221 FILE: utilities/ovn-ctl:1439:
--db-ovnbr-addr=ADDR OVN_Bridge_Controller db ptcp address (default:
$DB_OVNBR_ADDR)
WARNING: Line is 86 characters long (recommended limit is 79)
#222 FILE: utilities/ovn-ctl:1440:
--db-ovnbr-port=PORT OVN_Bridge_Controller db ptcp port (default:
$DB_OVNBR_PORT)
WARNING: Line is 100 characters long (recommended limit is 79)
#223 FILE: utilities/ovn-ctl:1441:
--db-ovnbr-ctrl-sock=SOCKET OVN_Bridge_Controller db control socket (default:
$DB_OVNBR_CTRL_SOCK)
WARNING: Line is 87 characters long (recommended limit is 79)
#224 FILE: utilities/ovn-ctl:1442:
--ovn-ovnbr-logfile=FILE OVN_Bridge_Controller log file (default:
$OVN_OVNBR_LOGFILE)
WARNING: Line is 127 characters long (recommended limit is 79)
#225 FILE: utilities/ovn-ctl:1443:
--db-ovnbr-create-insecure-remote=yes|no Create ptcp OVN_Bridge_Controller
remote (default: $DB_OVNBR_CREATE_INSECURE_REMOTE)
WARNING: Line is 81 characters long (recommended limit is 79)
#310 FILE: utilities/ovn-ctl.8.xml:117:
<p><code>--ovn-br-controller-ssl-bootstrap-ca-cert=<var>CERT</var></code></p>
Lines checked: 352, Warnings: 29, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
