On 12/3/25 3:50 PM, Xavier Simonart via dev wrote: > Hi Dumitru > > Thanks for reviewing this patch. > Will send v2 (comments below). > > Thanks > Xavier > > On Wed, Dec 3, 2025 at 3:03 PM Dumitru Ceara <[email protected]> wrote: > >> On 12/3/25 2:22 PM, Xavier Simonart wrote: >>> 0x00000000005101f4 in ovsdb_idl_row_is_synthetic (row=0x0) at >> lib/ovsdb-idl.c:2724 >>> ovsdb_idl_txn_delete (row_=0x0) at lib/ovsdb-idl.c:3834 >>> 0x000000000043acdd in port_group_nb_port_group_handler (node=<optimized >> out>, data_=<optimized out>) at northd/en-port-group.c:616 >>> 0x000000000045b7db in engine_compute (node=<optimized out>, >> recompute_allowed=<optimized out>) at lib/inc-proc-eng.c:473 >>> engine_run_node (node=0x74cb20 <en_port_group>, >> recompute_allowed=<optimized out>) at lib/inc-proc-eng.c:545 >>> engine_run (recompute_allowed=recompute_allowed@entry=true) at >> lib/inc-proc-eng.c:571 >>> 0x000000000044d58b in inc_proc_northd_run >>> (ovnnb_txn=ovnnb_txn@entry=0xdd68060, >> ovnsb_txn=ovnsb_txn@entry=0xdd66ed0, ctx=ctx@entry=0x7ffe3be7ab60) at >> northd/inc-proc-northd.c:580 >>> 0x00000000004047d6 in main (argc=<optimized out>, argv=<optimized out>) >> at northd/ovn-northd.c:1096 >>> >>> Signed-off-by: Xavier Simonart <[email protected]> >>> --- >> >> Hi Xavier, >> >> Thanks for the fix! >> >> I guess we're missing a "Fixes:" tag here. >> >> Also maybe it's a bit more readable if we skip the backtrace from the >> commit message? In the end what we need to say is that >> sb_port_group_lookup_by_name() can return NULL if the (stale) record >> it's searching for has been deleted in transactions that are processed >> in the current iteration. What do you think? >> > Looks much better. > If you're ok, I would add the explanation you provided but would keep the > last lines of the stack trace (maybe w/o the address). > I found it sometimes easier when hitting a segfault and checking whether > this is an already fixed one if the patch has some kind of stack trace..
FWIW, I normally just simplify the trace by removing all the unnecessary addresses and variables that are optimized out or otherwise inconsequential to the issue at hand. Keeping mostly the function and file names and the line numbers, and maybe some variables, if they are actually important. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
