Hi Ilya Thanks for the review and feedback
On Fri, Dec 5, 2025 at 3:05 PM Ilya Maximets <[email protected]> wrote: > On 12/5/25 2:58 PM, Dumitru Ceara via dev wrote: > > Hi Xavier, > > > > On 12/5/25 2:57 PM, Xavier Simonart wrote: > >>>> +AS_BOX([$(date +%H:%M:%S.%03N) Add/delete LSP while northd is > sleeping]) > >>> Do we really need the date in the output? Is this a left over from > your > >>> debugging? > >>> > >> In tests such as this one which repeat similar operations multiple times > >> (e.g we delete > >> three times ls1) I found it much easier to have a date in the > >> testsuite.log, so we can easily > >> find in other logs or db what happens at that time. So yes, it's > debugging, > >> but does not cost much > >> and should not influence the dynamics of the test (as would a vlog/set > dbg > >> for instance). > >> So I find it easier if we keep the date, but I can remove it if you > find we > >> should not have such debug info > >> in the tests. > > > > That's fine, let's keep it if it adds value. > > Not sure if we care much, but just a note that %03N is not portable and > requires GNU date. Will not work on mac or bsd, but it's also unlikely > to be supported in busybox, so will not work on apline linux and some > other embedded-friendly systems. > OVN documents it supports bsd, so we should probably avoid using non portable code. There are other occurrences of date %03N in tests, and maybe also other non portable features used, so a different task should clean this out. For now, I will skip the "date ... %N" in v2 (v2 is needed anyhow per Dumitru's feedback). > > Best regards, Ilya Maximets. > Thanks Xavier _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
