On 15 Dec 2025, at 14:38, Simon Horman wrote:

> On Mon, Dec 15, 2025 at 11:34:41AM +0100, Eelco Chaudron wrote:
>>
>>
>> On 12 Dec 2025, at 13:33, Simon Horman wrote:
>>
>>> It is some time now since the OOT kernel module was removed. It is yet
>>> longer since it was deprecated. And it is no longer present in any
>>> supported versions.
>>>
>>> However, running user-space with the OOT kernel module, from unsupported
>>> releases, is still supported.
>>>
>>> This notice deprecates that support as of the v3.7 release.
>>> With the intention to remove it in the v3.8 release.
>>>
>>> As discussed at OVS+OVN Conference 2025.
>>>
>>> Acked-by: Eelco Chaudron <[email protected]>
>>> Signed-off-by: Simon Horman <[email protected]>
>>
>> Thanks for following up, one comment regarding log message below.
>
> ...
>
>>> diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
>
> ...
>
>>> @@ -624,3 +624,16 @@ dpif_netlink_rtnl_probe_oot_tunnels(void)
>>>
>>>      return out_of_tree;
>>>  }
>>> +
>>> +bool
>>> +dpif_netlink_rtnl_probe_oot_tunnels(void)
>>> +{
>>> +    bool out_of_tree = __dpif_netlink_rtnl_probe_oot_tunnels();
>>> +
>>> +    if (out_of_tree) {
>>> +        VLOG_WARN_ONCE("Use of OOT kernel datapath module deprecated. "
>>> +                       "Please module proivided by upsteram kernel 
>>> instead.");
>>
>> Guess you missed the ‘use’ word in the sentence above.
>
> Yes. Sorry about that.
>
> I'll either re-spin or fix when applying depending on how other review goes.

Both sounds good to me, my ack still holds ;)

//Eelco

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to