On 12/15/25 10:34 AM, Frode Nordahl wrote:
> The tc command from iproute2 changed its rounding behavior in commit
> d947f365602b ("tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize.").
> This caused QoS tests to be fragile because they were matching exact burst
> and cburst values in tc output.
>
> The rounding fix means that burst and cburst values may differ slightly
> from previous versions. For example, values that were previously 620000
> might now be 618750 or similar variations.
>
> To maintain compatibility with both old and new versions of tc, the test
> assertions now use pattern matching that:
> - Matches the most significant digit(s) of the value
> - Ensures all characters are numeric
> - Maintains the correct total number of digits
> - Preserves the unit suffix (e.g., 'b' for bytes)
>
> For example, '375000b' now matches '3[0-9][0-9][0-9][0-9][0-9]b' which
> accepts any 6-digit value starting with 3, allowing for rounding
> differences while still validating the general magnitude is correct.
>
> This follows the same approach as the related OVN patch:
> https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/
Thanks, Frode! I'm marking this as changes-requested for now, as the same
review comments from the OVN patch should apply here.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
