On 12/15/25 9:29 AM, David Marchand wrote: > On Thu, 11 Dec 2025 at 19:51, Ilya Maximets <[email protected]> wrote: >> >> Kernels with AF_XDP support below v5.4 are not supported and are not >> used in any major distributions. Using kernels that old with AF_XDP >> that was rapidly changing at the time is also not a good idea in >> general. Let's drop support for them. This allows to have the >> XDP_USE_NEED_WAKEUP flag to be always on, so we can simplify the code >> and stop guessing how many packets kernel can send in one go. >> >> The next milestone may be to require libxdp 1.2+ and kernel 5.18+, so >> we can simplify acinclude.m4 and avoid checking for bpf_xdp_detach and >> bpf_xdp_query_id API. But it feels a little bit too early for that, >> as it excludes Ubuntu 22.04, even if it's probably not a great idea >> to run AF_XDP there either. The gains from moving the pole to 5.18 >> are just a couple of checks in the code, so not doing that for now. >> >> Signed-off-by: Ilya Maximets <[email protected]> > > On the principle, it lgtm. > However, use_need_wakeup / requested_need_wakeup were left behind in > lib/netdev-linux-private.h.
Missed those somehow. Thanks! I'll send a v2. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
