On Mon, Dec 15, 2025 at 09:40:11PM +0100, Ilya Maximets wrote:
> On 12/12/25 1:34 PM, Simon Horman wrote:
> > Deprecate Windows support which has become increasingly difficult to
> > maintain.
> > 
> > As discussed at OVS+OVN Conference 2025.
> > 
> > Signed-off-by: Simon Horman <[email protected]>
> > ---
> > Windows build, featuring deprecation warning message, here:
> > https://ci.appveyor.com/project/horms/ovs/builds/53224365
> > ---
> >  NEWS                           | 2 ++
> >  include/openvswitch/compiler.h | 4 ++++
> >  2 files changed, 6 insertions(+)
> 
> Thanks, Simon.  It is indeed a noticeable time sink at least for me to keep
> the Windows CI afloat when it breaks for one reason or another.  Mainly 
> because
> myself and most other maintainers are not windows developers and have very
> limited experience with the system and the code.  Between the general lack of
> development and the community interest in the area and increasing burden of
> maintenance (we still don't have support for the 5 years old VS 2021 or 
> Win11),
> and the complete absence of any functional testing in CI, it makes sense to
> deprecate it.
> 
> > diff --git a/NEWS b/NEWS
> > index 
> > f9a74df1ad52aaadf94925b34c12b3dbc028bf7d..944f047a8b1e017adfd0675996b45a7cb5c1eb38
> >  100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -16,6 +16,8 @@ Post-v3.6.0
> >       * New ovsdb_idl_txn_assert_read_only() interface to mark transactions
> >         as read-only and trigger assertion failure when application attempts
> >         to modify the database data through this transaction.
> > +   - Windows Support
> > +     * Support for compiling for and running on Windows has been 
> > deprecated.
> >  
> >  
> >  v3.6.0 - 18 Aug 2025
> > diff --git a/include/openvswitch/compiler.h b/include/openvswitch/compiler.h
> > index 
> > bd30369a78eeded10f78815b5c4bfe08a5e9c675..7dee9ec7a63ad27c7b3851f10eeeeed37427a338
> >  100644
> > --- a/include/openvswitch/compiler.h
> > +++ b/include/openvswitch/compiler.h
> > @@ -283,6 +283,10 @@
> >      ((size_t)((char *)&(((type *)0)->member) - (char *)0))
> >  #endif
> >  
> > +#if _MSC_VER
> > +#pragma message ("warning: Windows support is deprecated.")
> > +#endif
> Printing the warning 300 times during the build might be a little excessive. 
> :)
> But at the same time, it may actually be the only way to make it visible among
> all other warnings that the windows build emits...
> 
> Alternative might be to emit the warning when we're detecting windows during
> the configuration process in OVS_CHECK_WIN32.
> 
> I'll leave the decision up to you.  The current patch seems fine as well:
> 
> Acked-by: Ilya Maximets <[email protected]>

Thanks Ilya,

I will plan to apply this patch as-is.

I do agree that 300 times may be excessive.
But at the same time I'm not convinced that it's doing anyone any harm.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to