On 12/15/25 10:09 PM, Frode Nordahl wrote:
> The tc command from iproute2 changed its rounding behavior in commit
> d947f365602b ("tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize.").
> This caused the ovn-egress-qos tests to fail because they were matching
> exact burst and cburst values in tc output.
>
> The rounding fix means that burst and cburst values may differ slightly
> from previous versions. For example, values that were previously 750000
> might now be 749999 or similar variations.
>
> To maintain compatibility with both old and new versions of tc, the test
> assertions now use pattern matching with dots that:
> - Matches the most significant digit of the value
> - Uses dots to match any character for remaining digits
> - Maintains the correct total number of digits
> - Preserves the unit suffix (e.g., 'b' for bytes)
>
> For example, '375000b' now matches '3.....b' which accepts any 6-digit
> value starting with 3, allowing for rounding differences while still
> validating the general magnitude is correct.
>
> Reported-at: https://launchpad.net/bugs/2129005
> Assisted-by: GitHub Copilot
> Signed-off-by: Frode Nordahl <[email protected]>
> ---
Hi Frode,
Thanks for this new revision! Applied to main and all stable branches
down to 24.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
