2016-12-08 2:05 GMT-08:00 Balazs Nemeth <[email protected]>: > Hi, > > > > I’m building OVS 2.6.1 with SSE4.2 CPU flag enabled, like this: > > ./boot.sh > > ./configure > > make -j CFLAGS="-msse4.2" > > > > I ran ‘make check’ as well, all UTs are passed except ‘2246: ovn -- dhcpv4 : > 1 HV, 2 LS, 2 LSPs/LS’. The problem is that the actual value of the > dhcp_opts is not the same as the $expected_dhcp_opts when checking > DHCPDISCOVER and DHCPREQUEST messages. Looks like the SSE4.2 support causes > this difference. If I modify the test case like below, this 2246 UT is > passed as well. Do you know why is the DHCP opts field changing when I build > with SSE4.2 CFLAG? How is this value calculated? Is it valid to modify the > test case like this? > >
The order of the options in the packet depends on the hash function used by the hmap container. In case of big endian architectures the murmur hash function returns different values. In case of SSE4.2 we don't use murmur hash, we use the CRC32 instructions. I've sent a patch that changes the test to ignore the order of the options here: https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/326009.html > > user@ubuntu:~/openvswitch> git diff v2.6.1 tests/ovn.at > > diff --git a/tests/ovn.at b/tests/ovn.at > > index 56d47e7..f12cb21 100644 > > --- a/tests/ovn.at > > +++ b/tests/ovn.at > > @@ -3681,7 +3681,7 @@ as hv1 ovs-ofctl dump-flows br-int > > # Send DHCPDISCOVER. > > offer_ip=`ip_to_hex 10 0 0 4` > > server_ip=`ip_to_hex 10 0 0 1` > > -expected_dhcp_opts=0104ffffff0003040a00000136040a000001330400000e10 > > +expected_dhcp_opts=36040a0000010104ffffff0003040a000001330400000e10 > > test_dhcp 1 f00000000001 01 $offer_ip ff1000000001 $server_ip > $expected_dhcp_opts > > > > # NXT_RESUMEs should be 1. > > @@ -3704,7 +3704,7 @@ rm -f 2.expected > > # Send DHCPREQUEST. > > offer_ip=`ip_to_hex 10 0 0 6` > > server_ip=`ip_to_hex 10 0 0 1` > > -expected_dhcp_opts=0104ffffff0003040a00000136040a000001330400000e10 > > +expected_dhcp_opts=36040a0000010104ffffff0003040a000001330400000e10 > > test_dhcp 2 f00000000002 03 $offer_ip ff1000000001 $server_ip > $expected_dhcp_opts > > > > # NXT_RESUMEs should be 2. > > > > Best regards, > > Balazs Nemeth > > > _______________________________________________ > discuss mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss > _______________________________________________ discuss mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
