I forgot to thank you for working on this. Thanks! ovs_instruction_name_from_type() takes an ovs_instruction_type, so its result should be invariant of the OpenFlow version.
ofpact_is_apply_actions() is only used in one place, to encode instructions, so it should be straightforward to update it. But please keep in mind the big picture. OVS tries to keep as much compatibility as it can among the various OpenFlow versions it supports. In this case, I guess this means that if a meter action is added via OpenFlow 1.5, and then dumped in OpenFlow 1.4 or earlier, then it should be translated to a meter instruction if it is in an appropriate position for that, or to an extension action that we would define if it is not. On Tue, Jun 06, 2017 at 03:25:41PM +0000, Ali Volkan Atli wrote: > ovs_instruction_name_from_type and ofpact_is_apply_actions > > Meter is instruction for OF1.3 but it is an action-set for OF1.5, so I need > to distinguish > > - Volkan > > ---- Ben Pfaff wrote ---- > > On Tue, Jun 06, 2017 at 12:37:56PM +0000, Ali Volkan Atli wrote: > > I'm trying to contribute meter action for OF1.5 by using the existing > > patch "https://patchwork.ozlabs.org/patch/731701/"; in which meter is > > instruction. Currently it seems working using ovs-ofctl, but I am not > > sure if I can pass the version info as a parameter to the related > > function, I need a little help from people who know OvS architecture. > > "pass the version info as a parameter to the related function"? What > function? _______________________________________________ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
