On Wed, Jan 17, 2018 at 10:25:36AM +0000, Vishal Deep Ajmera wrote:
> Hi Flavio,
> 
> I tried to look closer into ifup-ovs script particularly for OVSDPDKPort & 
> OVSDPDKBOND cases. 
> With the change given below (git diff) at the end OVSDPDKBOND case, I see 
> that the routes 
> are getting installed again after adding dpdkbond port to the bridge. Perhaps 
> the same fix 
> needs to be done for OVSDPDKPort case as well. I think we need to invoke 
> $OTHERSCRIPT
> (ifup-eth) for the bridge in each of the above cases.
> 
> Does this fix in ifup-ovs script makes sense ?  If you agree, I will post a 
> patch for review on 
> ovs-dev list.

What happens if you have two or more bonds or if we fix dpdk port too,
what happens when you have more than one?  I think you will see
errors/failures.

> ----
> diff --git a/rhel/etc_sysconfig_network-scripts_ifup-ovs 
> b/rhel/etc_sysconfig_network-scripts_ifup-ovs
> index b95220a..132ed29 100755
> --- a/rhel/etc_sysconfig_network-scripts_ifup-ovs
> +++ b/rhel/etc_sysconfig_network-scripts_ifup-ovs
> @@ -202,6 +202,7 @@ case "$TYPE" in
>                 ovs-vsctl -t ${TIMEOUT} \
>                         -- --if-exists del-port "$OVS_BRIDGE" "$DEVICE" \
>                         -- add-bond "$OVS_BRIDGE" "$DEVICE" ${BOND_IFACES} 
> $OVS_OPTIONS ${IFACE_TYPES} ${OVS_EXTRA+-- $OVS_EXTRA}
> +               ${OTHERSCRIPT} $OVS_BRIDGE
>                 ;;
>         *)
>                 echo $"Invalid OVS interface type $TYPE"
> ----

-- 
Flavio

_______________________________________________
discuss mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss

Reply via email to